Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-1687: Load NAGPRA reports in only core and anthro #453

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

mikejritter
Copy link
Contributor

What does this do?
This moves the report config for the new NAGPRA reports into the core and anthro tenant bindings. By doing this we ensure that the reports are only available for those tenants, as they are the only tenants with the procedures enabled for those reports.

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1687

In tenants other than core/anthro, the NAGPRA reports can be selected from the Tools > Reports interface. This has a modal which allows a user to select records to run the report on with a record type that does not exist in the tenant, and as such causes an error in the ui. Ideally we need error handling in the ui as well, but for the time being we've decided to fix things here for now.

How should this be tested? Do these changes have associated tests?

  • Build collectionspace without any changes
  • Save the files in ${CSPACE_JEE_SERVER}/cspace/config/services/tenants/
  • Rebuild collectionspace with the changes
  • Diff the merged tenant bindings, e.g.
git diff -w --no-index materials/tenant-bindings.merged.xml ~/tmt/saved-bindings/materials/tenant-bindings.merged.xml

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter ran the build and compared the tenant bindings

@mikejritter mikejritter merged commit 35ce9d4 into collectionspace:v8.1-branch Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant